From: Ashik Thomas (ashiktho) Date: Fri, 29 Sep 2023 07:19:38 +0000 (+0000) Subject: Pull request #4028: CSCwh22691 - Continuous snort3 cores in DCE/SMB - DC into 7.6... X-Git-Tag: 3.1.72.0~9 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=251e45c75605ac8a80c0fb2b170abbf5bda2ad1b;p=thirdparty%2Fsnort3.git Pull request #4028: CSCwh22691 - Continuous snort3 cores in DCE/SMB - DC into 7.6 release Merge in SNORT/snort3 from ~ASHIKTHO/snort3:CSCwh22691_master to master Squashed commit of the following: commit 21e36571ca53ccb7883eee3cfb9aaf9e4cf2a7ec Author: Sumit Kumar Date: Mon Aug 21 14:31:03 2023 +0530 dce_rpc: using reset_using_rpkt() inline to what is there in eval() of SMB inspector code as well --- diff --git a/src/service_inspectors/dce_rpc/dce_http_proxy.cc b/src/service_inspectors/dce_rpc/dce_http_proxy.cc index 3d9043586..cf4c9d938 100644 --- a/src/service_inspectors/dce_rpc/dce_http_proxy.cc +++ b/src/service_inspectors/dce_rpc/dce_http_proxy.cc @@ -41,7 +41,9 @@ THREAD_LOCAL DceHttpProxyStats dce_http_proxy_stats; class DceHttpProxy : public Inspector { public: - void eval(Packet*) override { } + void eval(Packet*) override { + reset_using_rpkt(); + } void clear(Packet*) override; StreamSplitter* get_splitter(bool c2s) override { diff --git a/src/service_inspectors/dce_rpc/dce_http_server.cc b/src/service_inspectors/dce_rpc/dce_http_server.cc index 1771c5024..3d749f587 100644 --- a/src/service_inspectors/dce_rpc/dce_http_server.cc +++ b/src/service_inspectors/dce_rpc/dce_http_server.cc @@ -41,7 +41,9 @@ THREAD_LOCAL DceHttpServerStats dce_http_server_stats; class DceHttpServer : public Inspector { public: - void eval(Packet*) override { } + void eval(Packet*) override { + reset_using_rpkt(); + } void clear(Packet*) override; StreamSplitter* get_splitter(bool c2s) override { diff --git a/src/service_inspectors/dce_rpc/dce_tcp.cc b/src/service_inspectors/dce_rpc/dce_tcp.cc index 88d4e052f..3b6f58a7b 100644 --- a/src/service_inspectors/dce_rpc/dce_tcp.cc +++ b/src/service_inspectors/dce_rpc/dce_tcp.cc @@ -135,6 +135,8 @@ void Dce2Tcp::eval(Packet* p) assert(p->has_tcp_data()); assert(p->flow); + reset_using_rpkt(); + if ( p->test_session_flags(SSNFLAG_MIDSTREAM) ) { return; diff --git a/src/service_inspectors/dce_rpc/dce_udp.cc b/src/service_inspectors/dce_rpc/dce_udp.cc index 4efe6a5cd..e6315389f 100644 --- a/src/service_inspectors/dce_rpc/dce_udp.cc +++ b/src/service_inspectors/dce_rpc/dce_udp.cc @@ -134,6 +134,8 @@ void Dce2Udp::eval(Packet* p) assert(p->flow); + reset_using_rpkt(); + dce2_udp_sess = dce2_handle_udp_session(p, &config); if (dce2_udp_sess)