From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sun, 10 Jul 2022 14:27:58 +0000 (+0200)
Subject: 4.14-stable patches
X-Git-Tag: v4.9.323~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=253bf5e4337f4ece84c2d7003826eb5fa2dbaf89;p=thirdparty%2Fkernel%2Fstable-queue.git

4.14-stable patches

added patches:
	xfs-remove-incorrect-assert-in-xfs_rename.patch
---

diff --git a/queue-4.14/series b/queue-4.14/series
index 23113d06822..855f95e1b13 100644
--- a/queue-4.14/series
+++ b/queue-4.14/series
@@ -8,3 +8,4 @@ iommu-vt-d-fix-pci-bus-rescan-device-hot-add.patch
 fbcon-disallow-setting-font-bigger-than-screen-size.patch
 video-of_display_timing.h-include-errno.h.patch
 powerpc-powernv-delay-rng-platform-device-creation-until-later-in-boot.patch
+xfs-remove-incorrect-assert-in-xfs_rename.patch
diff --git a/queue-4.14/xfs-remove-incorrect-assert-in-xfs_rename.patch b/queue-4.14/xfs-remove-incorrect-assert-in-xfs_rename.patch
new file mode 100644
index 00000000000..de628bc01e4
--- /dev/null
+++ b/queue-4.14/xfs-remove-incorrect-assert-in-xfs_rename.patch
@@ -0,0 +1,40 @@
+From kuniyu@amazon.com  Sun Jul 10 16:25:33 2022
+From: Kuniyuki Iwashima <kuniyu@amazon.com>
+Date: Thu, 7 Jul 2022 16:07:53 -0700
+Subject: xfs: remove incorrect ASSERT in xfs_rename
+To: <stable@vger.kernel.org>, <linux-xfs@vger.kernel.org>
+Cc: Kuniyuki Iwashima <kuniyu@amazon.com>, Ke Xu <kkexu@amazon.com>, "Ayushman Dutta" <ayudutta@amazon.com>, Eric Sandeen <sandeen@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Darrick J . Wong" <djwong@kernel.org>
+Message-ID: <20220707230753.32743-1-kuniyu@amazon.com>
+
+From: Eric Sandeen <sandeen@redhat.com>
+
+commit e445976537ad139162980bee015b7364e5b64fff upstream.
+
+This ASSERT in xfs_rename is a) incorrect, because
+(RENAME_WHITEOUT|RENAME_NOREPLACE) is a valid combination, and
+b) unnecessary, because actual invalid flag combinations are already
+handled at the vfs level in do_renameat2() before we get called.
+So, remove it.
+
+Reported-by: Paolo Bonzini <pbonzini@redhat.com>
+Signed-off-by: Eric Sandeen <sandeen@redhat.com>
+Reviewed-by: Darrick J. Wong <djwong@kernel.org>
+Signed-off-by: Darrick J. Wong <djwong@kernel.org>
+Fixes: 7dcf5c3e4527 ("xfs: add RENAME_WHITEOUT support")
+Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
+Acked-by: Darrick J. Wong <djwong@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/xfs/xfs_inode.c |    1 -
+ 1 file changed, 1 deletion(-)
+
+--- a/fs/xfs/xfs_inode.c
++++ b/fs/xfs/xfs_inode.c
+@@ -2964,7 +2964,6 @@ xfs_rename(
+ 	 * appropriately.
+ 	 */
+ 	if (flags & RENAME_WHITEOUT) {
+-		ASSERT(!(flags & (RENAME_NOREPLACE | RENAME_EXCHANGE)));
+ 		error = xfs_rename_alloc_whiteout(target_dp, &wip);
+ 		if (error)
+ 			return error;