From: Razvan Becheriu <razvan@isc.org>
Date: Sat, 1 Nov 2025 12:26:11 +0000 (+0200)
Subject: [#4206] fixed data race
X-Git-Tag: Kea-3.1.4~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2549a70792841d43524beaa6f1887e5f6d9345d3;p=thirdparty%2Fkea.git

[#4206] fixed data race
---

diff --git a/src/hooks/dhcp/ping_check/ping_check_mgr.cc b/src/hooks/dhcp/ping_check/ping_check_mgr.cc
index 0a9231292a..472e4a8168 100644
--- a/src/hooks/dhcp/ping_check/ping_check_mgr.cc
+++ b/src/hooks/dhcp/ping_check/ping_check_mgr.cc
@@ -722,6 +722,10 @@ PingCheckMgr::stop() {
     // Cancel the expiration timer.
     cancelExpirationTimer();
 
+    if (thread_pool_) {
+        thread_pool_->pause();
+    }
+
     if (channel_) {
         channel_->close();
     }
diff --git a/src/hooks/dhcp/ping_check/tests/ping_check_mgr_unittests.cc b/src/hooks/dhcp/ping_check/tests/ping_check_mgr_unittests.cc
index af70317d7e..b370e03d8c 100644
--- a/src/hooks/dhcp/ping_check/tests/ping_check_mgr_unittests.cc
+++ b/src/hooks/dhcp/ping_check/tests/ping_check_mgr_unittests.cc
@@ -1482,6 +1482,9 @@ public:
 
         // We should have one free that matches our lease query pair.
         compareLeaseQueryPairs(frees_);
+
+        // Stop the mgr.
+        ASSERT_NO_THROW(mgr_->stop());
     }
 
     /// @brief Exercises shouldPing().