From: Noel Power <noel.power@suse.com>
Date: Wed, 14 Aug 2019 13:53:01 +0000 (+0100)
Subject: s3/libsmb: clang: Fix 'warning: Assigned value is garbage or undefined '
X-Git-Tag: tevent-0.10.1~126
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2575e4066bf84d7a56f0b7126841f4ea5cc027fd;p=thirdparty%2Fsamba.git

s3/libsmb: clang: Fix 'warning: Assigned value is garbage or undefined '

Fixes:

source3/libsmb/clireadwrite.c:1259:17: warning: Assigned value is garbage or undefined <--[clang]
        state->written += written;
                       ^  ~~~~~~~

source3/libsmb/clireadwrite.c:1722:14: warning: The left operand of '>' is a garbage value <--[clang]
        if (written > expected) {
            ~~~~~~~ ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Aug 28 00:22:49 UTC 2019 on sn-devel-184
---

diff --git a/source3/libsmb/clireadwrite.c b/source3/libsmb/clireadwrite.c
index a3c49442c10..9349b9485e8 100644
--- a/source3/libsmb/clireadwrite.c
+++ b/source3/libsmb/clireadwrite.c
@@ -1248,7 +1248,7 @@ static void cli_smb1_writeall_written(struct tevent_req *subreq)
 	struct cli_smb1_writeall_state *state = tevent_req_data(
 		req, struct cli_smb1_writeall_state);
 	NTSTATUS status;
-	size_t written, to_write;
+	size_t written = 0, to_write;
 
 	status = cli_write_andx_recv(subreq, &written);
 	TALLOC_FREE(subreq);