From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 3 Apr 2020 23:22:41 +0000 (-0600)
Subject: global: Have instance_count underflow if the free function is called too many times...
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=258b05905afa42a4d17f2a95194640ea4629a169;p=thirdparty%2Ffreeradius-server.git

global: Have instance_count underflow if the free function is called too many times...
---

diff --git a/src/lib/curl/base.c b/src/lib/curl/base.c
index 6778ed2d197..772b8000a4d 100644
--- a/src/lib/curl/base.c
+++ b/src/lib/curl/base.c
@@ -29,7 +29,7 @@
 #include <curl/curl.h>
 #include <talloc.h>
 
-static int instance_count;
+static uint32_t instance_count;
 
 /** Initialise global curl options
  *
diff --git a/src/lib/eap_aka_sim/base.c b/src/lib/eap_aka_sim/base.c
index da08948f676..360b0c34a94 100644
--- a/src/lib/eap_aka_sim/base.c
+++ b/src/lib/eap_aka_sim/base.c
@@ -40,7 +40,7 @@ RCSID("$Id$")
 #include <freeradius-devel/eap_aka_sim/base.h>
 #include <freeradius-devel/eap_aka_sim/attrs.h>
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 fr_dict_t const *dict_freeradius;
 fr_dict_t const *dict_radius;
diff --git a/src/lib/ldap/base.c b/src/lib/ldap/base.c
index f772e8566b6..7f33978139b 100644
--- a/src/lib/ldap/base.c
+++ b/src/lib/ldap/base.c
@@ -38,7 +38,7 @@ USES_APPLE_DEPRECATED_API
 
 LDAP *ldap_global_handle;			//!< Hack for OpenLDAP libldap global initialisation.
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 /** Used to set the global log prefix for functions which don't operate on connections
  *
diff --git a/src/lib/sim/base.c b/src/lib/sim/base.c
index 08e9dbd63b6..a398ae6f4ca 100644
--- a/src/lib/sim/base.c
+++ b/src/lib/sim/base.c
@@ -38,7 +38,7 @@ RCSID("$Id$")
 #include "base.h"
 #include "attrs.h"
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 fr_dict_t *dict_freeradius;
 fr_dict_t *dict_radius;
diff --git a/src/lib/soh/soh.c b/src/lib/soh/soh.c
index c76b5cf3e0d..a9de26d1c2c 100644
--- a/src/lib/soh/soh.c
+++ b/src/lib/soh/soh.c
@@ -122,7 +122,7 @@ fr_dict_attr_autoload_t soh_dict_attr[] = {
 	{ NULL }
 };
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 /** Read big-endian 2-byte unsigned from p
  *
diff --git a/src/lib/tls/base.c b/src/lib/tls/base.c
index 5dcf3780c00..f2d05ffa5c5 100644
--- a/src/lib/tls/base.c
+++ b/src/lib/tls/base.c
@@ -37,7 +37,7 @@ USES_APPLE_DEPRECATED_API	/* OpenSSL API has been deprecated by Apple */
 #include "base.h"
 #include "attrs.h"
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 /** The context which holds any memory OpenSSL allocates
  *
diff --git a/src/protocols/dhcpv4/base.c b/src/protocols/dhcpv4/base.c
index 2a039dc52ac..0544e1985a0 100644
--- a/src/protocols/dhcpv4/base.c
+++ b/src/protocols/dhcpv4/base.c
@@ -31,7 +31,7 @@ RCSID("$Id$")
 #include <freeradius-devel/util/pcap.h>
 #include "attrs.h"
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 typedef struct {
 	uint8_t		code;
diff --git a/src/protocols/dhcpv6/base.c b/src/protocols/dhcpv6/base.c
index ac6849b2a36..d3778d36fa8 100644
--- a/src/protocols/dhcpv6/base.c
+++ b/src/protocols/dhcpv6/base.c
@@ -39,7 +39,7 @@
 #include "dhcpv6.h"
 #include "attrs.h"
 
-static int instance_count;
+static uint32_t instance_count;
 
 fr_dict_t const *dict_dhcpv6;
 
diff --git a/src/protocols/radius/base.c b/src/protocols/radius/base.c
index d2130cf41b6..6e3fc3c8b0d 100644
--- a/src/protocols/radius/base.c
+++ b/src/protocols/radius/base.c
@@ -34,7 +34,7 @@ RCSID("$Id$")
 #include <freeradius-devel/util/udp.h>
 #include "attrs.h"
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 fr_dict_t const *dict_freeradius;
 fr_dict_t const *dict_radius;
diff --git a/src/protocols/vqp/base.c b/src/protocols/vqp/base.c
index bbe6197bedf..c4f61182a37 100644
--- a/src/protocols/vqp/base.c
+++ b/src/protocols/vqp/base.c
@@ -29,7 +29,7 @@ RCSID("$Id$")
 #include "vqp.h"
 #include "attrs.h"
 
-static int instance_count = 0;
+static uint32_t instance_count = 0;
 
 fr_dict_t const *dict_vmps;