From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 3 Aug 2023 07:39:03 +0000 (+0200)
Subject: remote_driver: Drop explicit memset(&sargs) in remoteAuthSASL()
X-Git-Tag: v9.7.0-rc1~165
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=258fc73cf051419d19947059a98f1d6a2d1d4910;p=thirdparty%2Flibvirt.git

remote_driver: Drop explicit memset(&sargs) in remoteAuthSASL()

Inside of remoteAuthSASL() the sargs variable is already
initialized to zero during declaration. There's no need to
memset() it again as it's unused in between it's declaration and
said memset().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
---

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index d775f65fe2..7ccf550dff 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -3833,7 +3833,6 @@ remoteAuthSASL(virConnectPtr conn, struct private_data *priv,
         goto cleanup;
     }
     /* NB, distinction of NULL vs "" is *critical* in SASL */
-    memset(&sargs, 0, sizeof(sargs));
     sargs.nil = clientout ? 0 : 1;
     sargs.data.data_val = (char*)clientout;
     sargs.data.data_len = clientoutlen;