From: Serhiy Storchaka <storchaka@gmail.com>
Date: Fri, 23 Jan 2026 18:55:48 +0000 (+0200)
Subject: gh-144027: Fix documentation for ignorechars in base64.a85decode() (GH-144028)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=25a10b60b04ab2fa802409dc6f211cf2ca028a0a;p=thirdparty%2FPython%2Fcpython.git

gh-144027: Fix documentation for ignorechars in base64.a85decode() (GH-144028)

It does not support an ASCII string.

Also add more tests.
---

diff --git a/Doc/library/base64.rst b/Doc/library/base64.rst
index 3e7884debd59..64d66fcf6bd5 100644
--- a/Doc/library/base64.rst
+++ b/Doc/library/base64.rst
@@ -254,8 +254,7 @@ Refer to the documentation of the individual functions for more information.
    *adobe* controls whether the input sequence is in Adobe Ascii85 format
    (i.e. is framed with <~ and ~>).
 
-   *ignorechars* should be a :term:`bytes-like object` or ASCII string
-   containing characters to ignore
+   *ignorechars* should be a byte string containing characters to ignore
    from the input. This should only contain whitespace characters, and by
    default contains all whitespace characters in ASCII.
 
diff --git a/Lib/test/test_base64.py b/Lib/test/test_base64.py
index d02992903f15..6e69ece8065e 100644
--- a/Lib/test/test_base64.py
+++ b/Lib/test/test_base64.py
@@ -965,6 +965,19 @@ class BaseXYTestCase(unittest.TestCase):
         self.assertRaises(ValueError, base64.a85decode, b'aaaay',
                           foldspaces=True)
 
+        self.assertEqual(base64.a85decode(b"a b\nc", ignorechars=b" \n"),
+                         b'\xc9\x89')
+        with self.assertRaises(ValueError):
+            base64.a85decode(b"a b\nc", ignorechars=b"")
+        with self.assertRaises(ValueError):
+            base64.a85decode(b"a b\nc", ignorechars=b" ")
+        with self.assertRaises(ValueError):
+            base64.a85decode(b"a b\nc", ignorechars=b"\n")
+        with self.assertRaises(TypeError):
+            base64.a85decode(b"a b\nc", ignorechars=" \n")
+        with self.assertRaises(TypeError):
+            base64.a85decode(b"a b\nc", ignorechars=None)
+
     def test_b85decode_errors(self):
         illegal = list(range(33)) + \
                   list(b'"\',./:[\\]') + \