From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 21 Feb 2026 07:04:26 +0000 (-0700)
Subject: Fix memory leak and deadlock on error path in cache module
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=25ab8b97ec4e7de10d632a8762ded7b8d47ca52f;p=thirdparty%2Ffreeradius-server.git

Fix memory leak and deadlock on error path in cache module
---

diff --git a/src/modules/rlm_cache/rlm_cache.c b/src/modules/rlm_cache/rlm_cache.c
index 581102dd54a..98535fbbf7c 100644
--- a/src/modules/rlm_cache/rlm_cache.c
+++ b/src/modules/rlm_cache/rlm_cache.c
@@ -958,6 +958,9 @@ xlat_action_t cache_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 		if (unlikely(fr_value_box_copy(vb, vb, tmpl_value(map->rhs)) < 0)) {
 			RPEDEBUG("Failed copying value from cache entry");
 			talloc_free(vb);
+			talloc_free(target);
+			cache_free(inst, &c);
+			cache_release(inst, request, &handle);
 			return XLAT_ACTION_FAIL;
 		}
 		fr_dcursor_append(out, vb);