From: Douglas Bagnall Date: Wed, 13 Dec 2023 23:50:31 +0000 (+1300) Subject: libcli/security: allow SDDL conditional ACE round-trip for -00 and -0x0 X-Git-Tag: talloc-2.4.2~331 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=25f8e5079315b97279dd7d174aeb98241c3d8b5a;p=thirdparty%2Fsamba.git libcli/security: allow SDDL conditional ACE round-trip for -00 and -0x0 Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/libcli/security/sddl_conditional_ace.c b/libcli/security/sddl_conditional_ace.c index 3d87a2bfafb..b5d0a3afa3a 100644 --- a/libcli/security/sddl_conditional_ace.c +++ b/libcli/security/sddl_conditional_ace.c @@ -670,7 +670,7 @@ static bool sddl_write_int(struct sddl_write_context *ctx, return sddl_write(ctx, "-0x8000000000000000"); } - buf[0] = (v < 0) ? '-' : '+'; + buf[0] = (sign == CONDITIONAL_ACE_INT_SIGN_NEGATIVE) ? '-' : '+'; if (base == CONDITIONAL_ACE_INT_BASE_8) { snprintf(buf + 1, sizeof(buf) - 1, "0%llo", llabs(v)); diff --git a/selftest/knownfail.d/sddl-conditional-ace b/selftest/knownfail.d/sddl-conditional-ace deleted file mode 100644 index 6d3a8612f95..00000000000 --- a/selftest/knownfail.d/sddl-conditional-ace +++ /dev/null @@ -1 +0,0 @@ -amba.unittests.sddl_conditional_ace.test_round_trips