From: Francis Dupont <fdupont@isc.org>
Date: Wed, 24 Jun 2015 11:02:06 +0000 (+0200)
Subject: [3919] Passed objects by reference
X-Git-Tag: trac3911_base~5^2~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2623b11a8d01770d131028f7503876d0497c10b6;p=thirdparty%2Fkea.git

[3919] Passed objects by reference
---

diff --git a/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc b/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
index 9b8e2247b7..2013b28918 100644
--- a/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
+++ b/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
@@ -2086,7 +2086,7 @@ TEST_F(Dhcpv6SrvTest, relayOverrideAndClientClass) {
 /// @param codes a vector of option codes to be created
 /// @param payload specified payload (0 = fill payload with repeating option code)
 /// @return RSOO with nested options
-OptionPtr createRSOO(const std::vector<uint16_t> codes, uint8_t payload = 0) {
+OptionPtr createRSOO(const std::vector<uint16_t>& codes, uint8_t payload = 0) {
     OptionDefinitionPtr def = LibDHCP::getOptionDef(Option::V6, D6O_RSOO);
     if (!def) {
         isc_throw(BadValue, "Can't find RSOO definition");
diff --git a/src/bin/dhcp6/tests/fqdn_unittest.cc b/src/bin/dhcp6/tests/fqdn_unittest.cc
index ed72b485f5..63885496d5 100644
--- a/src/bin/dhcp6/tests/fqdn_unittest.cc
+++ b/src/bin/dhcp6/tests/fqdn_unittest.cc
@@ -389,7 +389,7 @@ public:
                             const std::string& exp_hostname,
                             const uint8_t client_flags =
                                 Option6ClientFqdn::FLAG_S,
-                            const IOAddress expected_address = IOAddress("2001:db8:1:1::dead:beef"),
+                            const IOAddress& expected_address = IOAddress("2001:db8:1:1::dead:beef"),
                             const bool include_oro = true) {
         // Create a message of a specified type, add server id and
         // FQDN option.