From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Date: Wed, 25 Mar 2009 09:15:46 +0000 (+0100)
Subject: tests: CuTmpdir.pm: avoid use of undefined variable in warning
X-Git-Tag: v7.2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=26559b513dd51a8adb941829b46c162d90434f7d;p=thirdparty%2Fcoreutils.git

tests: CuTmpdir.pm: avoid use of undefined variable in warning

* tests/CuTmpdir.pm (chmod_tree): Do not warn if $dir is undefined.
---

diff --git a/tests/CuTmpdir.pm b/tests/CuTmpdir.pm
index 166e50bd83..1e52640862 100644
--- a/tests/CuTmpdir.pm
+++ b/tests/CuTmpdir.pm
@@ -1,7 +1,7 @@
 package CuTmpdir;
 # create, then chdir into a temporary sub-directory
 
-# Copyright (C) 2007-2008 Free Software Foundation, Inc.
+# Copyright (C) 2007-2009 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -45,7 +45,11 @@ sub chmod_1
 
 sub chmod_tree
 {
-  if (defined $dir && chdir $dir)
+  # When tempdir fails, it croaks, which leaves $dir undefined.
+  defined $dir
+    or return;
+
+  if (chdir $dir)
     {
       # Perform the equivalent of find . -type d -print0|xargs -0 chmod -R 700.
       my $options = {untaint => 1, wanted => \&chmod_1};