From: Roman Bogorodskiy Date: Sat, 13 Jun 2026 04:35:47 +0000 (+0200) Subject: qemu: use proper job type for qemuDomainAuthorizedSSHKeysSet() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=265e60f81ac1786ae13d99a366e611e06171e429;p=thirdparty%2Flibvirt.git qemu: use proper job type for qemuDomainAuthorizedSSHKeysSet() The qemuDomainAuthorizedSSHKeysSet() call currently uses VIR_AGENT_JOB_QUERY. While it's not an issue as this call does not modify any of the libvirt-stored state, semantically it modifies the domain, so VIR_AGENT_JOB_MODIFY fits better. Also, similar calls like qemuDomainSetUserPassword() or qemuDomainSetTime() already use VIR_AGENT_JOB_MODIFY, so use it in qemuDomainAuthorizedSSHKeysSet() too. Signed-off-by: Roman Bogorodskiy Reviewed-by: Peter Krempa --- diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b4cc09c81a..63afcceb93 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20396,7 +20396,7 @@ qemuDomainAuthorizedSSHKeysSet(virDomainPtr dom, if (virDomainAuthorizedSshKeysSetEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (virDomainObjBeginAgentJob(vm, VIR_AGENT_JOB_QUERY) < 0) + if (virDomainObjBeginAgentJob(vm, VIR_AGENT_JOB_MODIFY) < 0) goto cleanup; if (!qemuDomainAgentAvailable(vm, true))