From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Thu, 18 Jan 2024 14:58:41 +0000 (-0800)
Subject: Fix: doc link removal before assigning value (#5451)
X-Git-Tag: v2.4.0~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=26900e07669fa9e234ba1ca92aa7340f88fc6e22;p=thirdparty%2Fpaperless-ngx.git

Fix: doc link removal before assigning value (#5451)
---

diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py
index 34d8424439..942d22fe55 100644
--- a/src/documents/serialisers.py
+++ b/src/documents/serialisers.py
@@ -670,7 +670,10 @@ class DocumentSerializer(
             for custom_field_instance in instance.custom_fields.filter(
                 field__data_type=CustomField.FieldDataType.DOCUMENTLINK,
             ):
-                if custom_field_instance.field not in incoming_custom_fields:
+                if (
+                    custom_field_instance.field not in incoming_custom_fields
+                    and custom_field_instance.value is not None
+                ):
                     # Doc link field is being removed entirely
                     for doc_id in custom_field_instance.value:
                         CustomFieldInstanceSerializer.remove_doclink(