From: Matthew Nicholson <mnicholson@digium.com>
Date: Thu, 1 Jul 2010 14:34:31 +0000 (+0000)
Subject: Altered my comment about TCP_NODELAY
X-Git-Tag: 11.0.0-beta1~2753
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=269989c50f70ec4b40c3d3f07f7d9afa0c28d8c1;p=thirdparty%2Fasterisk.git

Altered my comment about TCP_NODELAY


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@273350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/manager.c b/main/manager.c
index 54d9760d26..678fd823e6 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -4610,10 +4610,9 @@ static void *session_do(void *data)
 		goto done;
 	}
 
- 	/* XXX here we set TCP_NODELAY on the socket to disable Nagle's
- 	 * algorithm.  A better solution might be to buffer outgoing messages
- 	 * until they are complete then write them to the socket in one burst
- 	 * rather than sending them in bits and pieces. */
+	/* here we set TCP_NODELAY on the socket to disable Nagle's algorithm.
+	 * This is necessary to prevent delays (caused by buffering) as we
+	 * write to the socket in bits and peices. */
   	p = getprotobyname("tcp");
   	if (p) {
   		int arg = 1;