From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 19 Jan 2024 07:54:37 +0000 (+0100)
Subject: dnstap: Fix a missed optimization reported by Coverity
X-Git-Tag: dnsdist-1.9.0-rc1~25^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=269e4dacfa3efde02f95e606fce141109f6bbc10;p=thirdparty%2Fpdns.git

dnstap: Fix a missed optimization reported by Coverity
---

diff --git a/pdns/dnstap.cc b/pdns/dnstap.cc
index beb7ac5e8d..b032da9876 100644
--- a/pdns/dnstap.cc
+++ b/pdns/dnstap.cc
@@ -63,7 +63,7 @@ std::string&& DnstapMessage::getBuffer()
 }
 
 DnstapMessage::DnstapMessage(std::string&& buffer, DnstapMessage::MessageType type, const std::string& identity, const ComboAddress* requestor, const ComboAddress* responder, DnstapMessage::ProtocolType protocol, const char* packet, const size_t len, const struct timespec* queryTime, const struct timespec* responseTime, const boost::optional<const DNSName&>& auth) :
-  d_buffer(buffer)
+  d_buffer(std::move(buffer))
 {
   protozero::pbf_writer pbf{d_buffer};