From: lpsolit%gmail.com <>
Date: Wed, 5 Aug 2009 01:28:52 +0000 (+0000)
Subject: Bug 508416: Bug flags are always displayed in the XML view of bugs - Patch by FrÃ... 
X-Git-Tag: bugzilla-3.4.2~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=26b64e70fdb9b8d88955035e85019c1d06998cdf;p=thirdparty%2Fbugzilla.git

Bug 508416: Bug flags are always displayed in the XML view of bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
---

diff --git a/show_bug.cgi b/show_bug.cgi
index 746167eefd..42fad71219 100755
--- a/show_bug.cgi
+++ b/show_bug.cgi
@@ -116,7 +116,7 @@ $vars->{'bug_list'} = \@bug_list;
 # If no explicit list is defined, we show all fields. We then exclude any
 # on the exclusion list. This is so you can say e.g. "Everything except 
 # attachments" without listing almost all the fields.
-my @fieldlist = (Bugzilla::Bug->fields, 'group', 'long_desc', 
+my @fieldlist = (Bugzilla::Bug->fields, 'flag', 'group', 'long_desc',
                  'attachment', 'attachmentdata', 'token');
 my %displayfields;
 
diff --git a/template/en/default/bug/show.xml.tmpl b/template/en/default/bug/show.xml.tmpl
index cb0b10a429..12c813d87f 100644
--- a/template/en/default/bug/show.xml.tmpl
+++ b/template/en/default/bug/show.xml.tmpl
@@ -62,18 +62,21 @@
       [% END %]
 
       [%# Bug Flags %]
-      [% FOREACH type = bug.flag_types %]
-        [% FOREACH flag = type.flags %]
-          <flag name="[% type.name FILTER xml %]"
-                id="[% flag.id FILTER xml %]"
-                status="[% flag.status FILTER xml %]"
-                setter="[% flag.setter.login FILTER email FILTER xml %]"
-          [% IF flag.requestee %]
-              requestee="[% flag.requestee.login FILTER email FILTER xml %]"
+      [% IF displayfields.flag %]
+        [% FOREACH type = bug.flag_types %]
+          [% FOREACH flag = type.flags %]
+            <flag name="[% type.name FILTER xml %]"
+                  id="[% flag.id FILTER xml %]"
+                  status="[% flag.status FILTER xml %]"
+                  setter="[% flag.setter.login FILTER email FILTER xml %]"
+              [% IF flag.requestee %]
+                  requestee="[% flag.requestee.login FILTER email FILTER xml %]"
+              [% END %]
+            />
           [% END %]
-          />
         [% END %]
       [% END %]
+
       [% IF displayfields.long_desc %]
         [% FOREACH c = bug.longdescs %]
           [% NEXT IF c.isprivate && !user.in_group(Param("insidergroup")) %]