From: Ron Dempster (rdempste) <rdempste@cisco.com>
Date: Fri, 29 Apr 2022 19:40:06 +0000 (+0000)
Subject: Pull request #3401: main: update analyzer command log message to copy the variable... 
X-Git-Tag: 3.1.29.0~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=26b846cf2a974c78554bbf66af6c92c71be37b1f;p=thirdparty%2Fsnort3.git

Pull request #3401: main: update analyzer command log message to copy the variable arguments before using them for the remote response

Merge in SNORT/snort3 from ~RDEMPSTE/snort3:va_list to master

Squashed commit of the following:

commit 97b88140885310f3b48bde24cc3770eb73ab68c5
Author: Ron Dempster (rdempste) <rdempste@cisco.com>
Date:   Fri Apr 29 10:22:19 2022 -0400

    main: update analyzer command log message to copy the variable arguments before using them for the remote response
---

diff --git a/src/main/analyzer_command.cc b/src/main/analyzer_command.cc
index 2b9c48241..2f192e5dd 100644
--- a/src/main/analyzer_command.cc
+++ b/src/main/analyzer_command.cc
@@ -44,9 +44,14 @@ using namespace snort;
 
 void AnalyzerCommand::log_message(ControlConn* ctrlcon, const char* format, va_list& ap)
 {
-    LogMessage(format, ap);
     if (ctrlcon && !ctrlcon->is_local())
-        ctrlcon->respond(format, ap);
+    {
+        va_list rap;
+        va_copy(rap, ap);
+        ctrlcon->respond(format, rap);
+        va_end(rap);
+    }
+    LogMessage(format, ap);
 }
 
 void AnalyzerCommand::log_message(ControlConn* ctrlcon, const char* format, ...)