From: Michal 'vorner' Vaner <michal.vaner@nic.cz>
Date: Fri, 7 Dec 2012 13:09:05 +0000 (+0100)
Subject: [2378] Simplify the loadIncremental code
X-Git-Tag: bind10-1.0.0-beta-release~28^2~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=27033b59dcaf34216802401f19ec0b51e572b098;p=thirdparty%2Fkea.git

[2378] Simplify the loadIncremental code

Some of the code can be shared between the variants, saving some code.
---

diff --git a/src/lib/datasrc/zone_loader.cc b/src/lib/datasrc/zone_loader.cc
index 4cb3e0d92b..5a36b32032 100644
--- a/src/lib/datasrc/zone_loader.cc
+++ b/src/lib/datasrc/zone_loader.cc
@@ -110,26 +110,18 @@ ZoneLoader::loadIncremental(size_t limit) {
 
     if (iterator_ == ZoneIteratorPtr()) {
         assert(loader_.get() != NULL);
-        if (loader_->loadIncremental(limit)) {
-            complete_ = true;
-            if (!loaded_ok_) {
-                isc_throw(MasterFileError, "Error while loading master file");
-            } else {
-                updater_->commit();
-            }
-            return (true);
-        } else {
-            return (false);
+        complete_ = loader_->loadIncremental(limit);
+        if (complete_ && !loaded_ok_) {
+            isc_throw(MasterFileError, "Error while loading master file");
         }
     } else {
-        if (copyRRsets(updater_, iterator_, limit)) {
-            updater_->commit();
-            complete_ = true;
-            return (true);
-        } else {
-            return (false);
-        }
+        complete_ = copyRRsets(updater_, iterator_, limit);
+    }
+
+    if (complete_) {
+        updater_->commit();
     }
+    return (complete_);
 }
 
 } // end namespace datasrc