From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 31 Aug 2016 17:22:07 +0000 (-0400)
Subject: Always log [bug] warnings from the unit tests.
X-Git-Tag: tor-0.2.9.3-alpha~103^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=273290d4fee31857d689ef5286e44dd268a9bd65;p=thirdparty%2Ftor.git

Always log [bug] warnings from the unit tests.

We should consider them bugs.  If they are happening intentionally,
we should use the log_test_helpers code to capture and suppress
them.  But having them off-by-default has potential to cause
programming errors.
---

diff --git a/src/test/testing_common.c b/src/test/testing_common.c
index ea9366305c..e3fe87cb43 100644
--- a/src/test/testing_common.c
+++ b/src/test/testing_common.c
@@ -272,6 +272,8 @@ main(int c, const char **v)
     log_severity_list_t s;
     memset(&s, 0, sizeof(s));
     set_log_severity_config(loglevel, LOG_ERR, &s);
+    /* ALWAYS log bug warnings. */
+    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
     add_stream_log(&s, "", fileno(stdout));
   }