From: Jason Ish Date: Fri, 8 Dec 2023 22:27:12 +0000 (-0600) Subject: defrag: minor cleanups X-Git-Tag: suricata-8.0.0-beta1~1441 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=276d3d6541327891b027bd5e3ee7994c58ea3fb3;p=thirdparty%2Fsuricata.git defrag: minor cleanups - typo in comment - remove debug function that is not used and no longer valid --- diff --git a/src/defrag.c b/src/defrag.c index 5c79d4d993..5afc107b2f 100644 --- a/src/defrag.c +++ b/src/defrag.c @@ -103,26 +103,6 @@ static DefragContext *defrag_context; RB_GENERATE(IP_FRAGMENTS, Frag_, rb, DefragRbFragCompare); -/** - * Utility/debugging function to dump the frags associated with a - * tracker. Only enable when unit tests are enabled. - */ -#if 0 -#ifdef UNITTESTS -static void -DumpFrags(DefragTracker *tracker) -{ - Frag *frag; - - printf("Dumping frags for packet: ID=%d\n", tracker->id); - TAILQ_FOREACH(frag, &tracker->frags, next) { - printf("-> Frag: frag_offset=%d, frag_len=%d, data_len=%d, ltrim=%d, skip=%d\n", frag->offset, frag->len, frag->data_len, frag->ltrim, frag->skip); - PrintRawDataFp(stdout, frag->pkt, frag->len); - } -} -#endif /* UNITTESTS */ -#endif - /** * \brief Reset a frag for reuse in a pool. */ @@ -266,7 +246,7 @@ Defrag4Reassemble(ThreadVars *tv, DefragTracker *tracker, Packet *p) } /* Check that we have all the data. Relies on the fact that - * fragments are inserted if frag_offset order. */ + * fragments are inserted in frag_offset order. */ Frag *frag = NULL; size_t len = 0; RB_FOREACH_FROM(frag, IP_FRAGMENTS, first) {