From: Oleksandr Fedorych -X (ofedoryc - SOFTSERVE INC at Cisco) <ofedoryc@cisco.com>
Date: Fri, 5 Sep 2025 23:48:47 +0000 (+0000)
Subject: Pull request #4890: decoder: improved decoding fails error message on tracer
X-Git-Tag: 3.9.6.0~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=276f6f08d8b8821ee1167301a218d213ad11200f;p=thirdparty%2Fsnort3.git

Pull request #4890: decoder: improved decoding fails error message on tracer

Merge in SNORT/snort3 from ~OFEDORYC/snort3:gtp-improved-logs to master

Squashed commit of the following:

commit d5b51d1f8e9d088b99a5f72c9a90606c67bd081e
Author: ofedoryc <ofedoryc@cisco.com>
Date:   Wed Sep 3 06:22:20 2025 -0400

    decoder: improved decoding fails error message on tracer
---

diff --git a/src/protocols/packet_manager.cc b/src/protocols/packet_manager.cc
index 1a67f05aa..7d76a965d 100644
--- a/src/protocols/packet_manager.cc
+++ b/src/protocols/packet_manager.cc
@@ -173,7 +173,10 @@ void PacketManager::handle_decode_failure(Packet* p, RawData& raw, const CodecDa
     // if the codec exists, it failed
     if (CodecManager::s_proto_map[to_utype(prev_prot_id)])
     {
-        PacketTracer::log_msg_only("Packet %" PRIu64": decoding error\n", p->context->packet_number);
+        PacketTracer::log_msg_only("Packet %" PRIu64": unable to decode as %s%s\n",
+            p->context->packet_number,
+            get_proto_name(prev_prot_id),
+            (prev_prot_id == ProtocolId::GTP) ? "-u" : "");
         s_stats[discards]++;
     }
     else