From: kiko%async.com.br <>
Date: Thu, 5 Aug 2004 20:43:48 +0000 (+0000)
Subject: Fix for bug 253562: Hours Worked (actual_time) is being listed as 1.
X-Git-Tag: bugzilla-2.19.1~94
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2774974964c541c312fb98e507a597964473e355;p=thirdparty%2Fbugzilla.git

Fix for bug 253562: Hours Worked (actual_time) is being listed as 1.
Cleans up Bugzilla::Bug::actual_time to do things the right way (dbi,
Bugzilla->user) and apparently fixes a problem limited to some
platforms. r=joel, a=justdave.
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 01d2321c40..31b48649b8 100755
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -289,12 +289,13 @@ sub actual_time {
 
     return $self->{'actual_time'} if exists $self->{'actual_time'};
 
-    if (&::UserInGroup(Param("timetrackinggroup"))) {
-        &::SendSQL("SELECT SUM(work_time)
-               FROM longdescs WHERE longdescs.bug_id=$self->{bug_id}");
-        $self->{'actual_time'} = &::FetchSQLData();
-    }
+    return undef unless Bugzilla->user->in_group(Param("timetrackinggroup"));
 
+    my $sth = Bugzilla->dbh->prepare("SELECT SUM(work_time)
+                                      FROM longdescs 
+                                      WHERE longdescs.bug_id=?");
+    $sth->execute($self->{bug_id});
+    $self->{'actual_time'} = $sth->fetchrow_array();
     return $self->{'actual_time'};
 }