From: Tomek Mrugalski <tomasz@isc.org>
Date: Mon, 24 Aug 2015 13:18:49 +0000 (+0200)
Subject: [3681_rebase] Changes after review
X-Git-Tag: trac3874_base~33^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=278a4e3117213c0af6ececbef24471b67d39ebf7;p=thirdparty%2Fkea.git

[3681_rebase] Changes after review

 - Indent fixed
 - Missing parameter descriptions added
---

diff --git a/src/lib/dhcpsrv/database_connection.h b/src/lib/dhcpsrv/database_connection.h
index a9dac1c5ca..d5d65cea7a 100755
--- a/src/lib/dhcpsrv/database_connection.h
+++ b/src/lib/dhcpsrv/database_connection.h
@@ -90,12 +90,11 @@ public:
     /// @param parameters Database access parameters (output of "parse").
     ///
     /// @return Redacted database access string.
-    static std::string redactedAccessString(
-            const DatabaseConnection::ParameterMap& parameters);
+    static std::string redactedAccessString(const ParameterMap& parameters);
 
 protected:
 
-    /// @brief list of parameters passed in dbconfig
+    /// @brief List of parameters passed in dbconfig
     ///
     /// That will be mostly used for storing database name, username,
     /// password and other parameters required for DB access. It is not
diff --git a/src/lib/dhcpsrv/mysql_connection.h b/src/lib/dhcpsrv/mysql_connection.h
index 03dfdba208..9ca68d901f 100755
--- a/src/lib/dhcpsrv/mysql_connection.h
+++ b/src/lib/dhcpsrv/mysql_connection.h
@@ -173,6 +173,8 @@ public:
     ///
     /// Creates the prepared statements for all of the SQL statements used
     /// by the MySQL backend.
+    /// @param tagged_statements an array of statements to be compiled
+    /// @param num_statements number of statements in tagged_statements
     ///
     /// @throw isc::dhcp::DbOperationError An operation on the open database has
     ///        failed.
diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.h b/src/lib/dhcpsrv/mysql_lease_mgr.h
index b03418f72a..1e25ed4826 100755
--- a/src/lib/dhcpsrv/mysql_lease_mgr.h
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.h
@@ -432,9 +432,6 @@ public:
     };
 
 private:
-    /// @brief MySQL connection
-    MySqlConnection conn_;
-
     /// @brief Add Lease Common Code
     ///
     /// This method performs the common actions for both flavours (V4 and V6)
@@ -611,7 +608,8 @@ private:
     boost::scoped_ptr<MySqlLease4Exchange> exchange4_; ///< Exchange object
     boost::scoped_ptr<MySqlLease6Exchange> exchange6_; ///< Exchange object
 
-
+    /// @brief MySQL connection
+    MySqlConnection conn_;
 };
 
 }; // end of isc::dhcp namespace