From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 21 Dec 2010 09:08:00 +0000 (+0100)
Subject: Final checked write for printing the VP
X-Git-Tag: release_2_1_11~179
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=279ad962248396be8bebe4ed82a810299e0e59c4;p=thirdparty%2Ffreeradius-server.git

Final checked write for printing the VP
---

diff --git a/src/modules/rlm_detail/rlm_detail.c b/src/modules/rlm_detail/rlm_detail.c
index 696b20a4426..3f1f2795bc7 100644
--- a/src/modules/rlm_detail/rlm_detail.c
+++ b/src/modules/rlm_detail/rlm_detail.c
@@ -218,11 +218,14 @@ static int checked_write(REQUEST *request, off_t *bytes_accum, FILE *fp,
 static int checked_write_vp(REQUEST *request, off_t *bytes_accum, FILE *fp,
 			    VALUE_PAIR *vp)
 {
-	if (checked_write(request, bytes_accum, fp, "\t") < 0) {
-		return -1;
-	}
-	vp_print(fp, vp);
-	if (checked_write(request, bytes_accum, fp, "\n") < 0) {
+	int len;
+	char buffer[1024];
+
+	buffer[0] = '\t';
+	len = vp_prints(buffer + 1, sizeof(buffer) - 2, vp);
+	buffer[len + 1] = '\n';
+
+	if (checked_write(request, bytes_accum, fp, "%s", buffer) < 0) {
 		return -1;
 	}