From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Tue, 22 Oct 2019 10:31:03 +0000 (+0200)
Subject: reference: don't clone file attributes of drift file
X-Git-Tag: 4.0-pre1~118
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=27c8a64977fb2e263eb38c4803439a669d3c0406;p=thirdparty%2Fchrony.git

reference: don't clone file attributes of drift file

When replacing an existing drift file with the temporary file, don't
change the ownership or permissions of the temporary file to match the
old drift file, as if it didn't exist.
---

diff --git a/reference.c b/reference.c
index b40ae381..9507d4e2 100644
--- a/reference.c
+++ b/reference.c
@@ -336,7 +336,6 @@ REF_GetLeapMode(void)
 static void
 update_drift_file(double freq_ppm, double skew)
 {
-  struct stat buf;
   char *temp_drift_file;
   FILE *out;
   int r1, r2;
@@ -370,16 +369,6 @@ update_drift_file(double freq_ppm, double skew)
     return;
   }
 
-  /* Clone the file attributes from the existing file if there is one. */
-
-  if (!stat(drift_file,&buf)) {
-    if (chown(temp_drift_file,buf.st_uid,buf.st_gid) ||
-        chmod(temp_drift_file,buf.st_mode & 0777)) {
-      LOG(LOGS_WARN, "Could not change ownership or permissions of temporary driftfile %s.tmp",
-          drift_file);
-    }
-  }
-
   /* Rename the temporary file to the correct location (see rename(2) for details). */
 
   if (rename(temp_drift_file,drift_file)) {