From: Willy Tarreau Date: Tue, 27 Jun 2017 13:47:56 +0000 (+0200) Subject: BUG/MAJOR: frontend: don't dereference a null conn on outgoing connections X-Git-Tag: v1.8-dev3~261 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=27f2dbbdfdb589bc5659cfdda2479c5fb47821fd;p=thirdparty%2Fhaproxy.git BUG/MAJOR: frontend: don't dereference a null conn on outgoing connections Recently merged commit 0cfe388 ("MINOR: frontend: retrieve the ALPN name when available") assumed that the connection is always known in frontend_accept() which is not true for outgoing peers connections for example. No backport needed. --- diff --git a/src/frontend.c b/src/frontend.c index 2480508503..8e2bf2fcdf 100644 --- a/src/frontend.c +++ b/src/frontend.c @@ -62,7 +62,7 @@ int frontend_accept(struct stream *s) /* check if we're in HTTP mode, directly connected to the connection, * and with ALPN advertising H2. */ - if (conn->owner == &s->si[0]) + if (conn && conn->owner == &s->si[0]) conn_get_alpn(conn, &alpn_str, &alpn_len); if ((fe->mode == PR_MODE_TCP || fe->mode == PR_MODE_HTTP)