From: Pauli <ppzgs1@gmail.com>
Date: Thu, 18 Mar 2021 23:41:34 +0000 (+1000)
Subject: params: fix coverity 1473069: unchecked return values
X-Git-Tag: openssl-3.0.0-alpha14~128
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=27f37279df67abc2ed8239435042de86ae3c74ca;p=thirdparty%2Fopenssl.git

params: fix coverity 1473069: unchecked return values

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14615)
---

diff --git a/crypto/params_from_text.c b/crypto/params_from_text.c
index bf3ca616410..50f48fdb7e3 100644
--- a/crypto/params_from_text.c
+++ b/crypto/params_from_text.c
@@ -29,6 +29,7 @@ static int prepare_from_text(const OSSL_PARAM *paramdefs, const char *key,
 {
     const OSSL_PARAM *p;
     size_t buf_bits;
+    int r;
 
     /*
      * ishex is used to translate legacy style string controls in hex format
@@ -49,11 +50,11 @@ static int prepare_from_text(const OSSL_PARAM *paramdefs, const char *key,
     case OSSL_PARAM_INTEGER:
     case OSSL_PARAM_UNSIGNED_INTEGER:
         if (*ishex)
-            BN_hex2bn(tmpbn, value);
+            r = BN_hex2bn(tmpbn, value);
         else
-            BN_asc2bn(tmpbn, value);
+            r = BN_asc2bn(tmpbn, value);
 
-        if (*tmpbn == NULL)
+        if (r == 0 || *tmpbn == NULL)
             return 0;
 
         /*