From: Volker Lendecke <vl@samba.org>
Date: Fri, 5 Jun 2026 09:37:55 +0000 (+0200)
Subject: tests: Fix some wbinfo_lookuprids_cache flakyness
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=27f57d26f950c6fbe62f9b8ef8bd5fb503f587e5;p=thirdparty%2Fsamba.git

tests: Fix some wbinfo_lookuprids_cache flakyness

If the key contains spaces, the shell qouting through "testit" does
not work properly. Avoid having to fix that quoting by replacing
spaces with '\20'.

You can force it by setting the

my $samsid = "S-1-5-21-1-32-" . int(rand(4294967295));

in selftest/target/Samba3.pm.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Jun  8 14:49:01 UTC 2026 on atb-devel-224
---

diff --git a/source3/script/tests/test_wbinfo_lookuprids_cache.sh b/source3/script/tests/test_wbinfo_lookuprids_cache.sh
index 7a5d0f7279a..ce71fb549bd 100755
--- a/source3/script/tests/test_wbinfo_lookuprids_cache.sh
+++ b/source3/script/tests/test_wbinfo_lookuprids_cache.sh
@@ -36,7 +36,7 @@ echo "$ndr_keys" | while IFS= read -r k; do
 	echo "  key='${k}' (length=${#k})"
 done
 
-key=$(echo "$ndr_keys" | head -1)
+key=$(echo "$ndr_keys" | head -1 | sed 's/ /\\20/g')
 echo "DEBUG: Using key='${key}' (length=${#key})"
 
 if [ -n "$key" ]; then