From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 4 Sep 2019 19:51:46 +0000 (-0400)
Subject: Tables no longer null terminated
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2801517c6d2fecd339317f4ef803591041ea7490;p=thirdparty%2Ffreeradius-server.git

Tables no longer null terminated
---

diff --git a/src/lib/server/xlat_builtin.c b/src/lib/server/xlat_builtin.c
index 4ac6680d175..4069d4bc5bb 100644
--- a/src/lib/server/xlat_builtin.c
+++ b/src/lib/server/xlat_builtin.c
@@ -465,6 +465,7 @@ static ssize_t xlat_func_debug_attr(UNUSED TALLOC_CTX *ctx, UNUSED char **out, U
 	     vp = fr_cursor_next(&cursor)) {
 		fr_dict_vendor_t const		*vendor;
 		fr_table_num_ordered_t const	*type;
+		size_t				i;
 
 		if (vp->da->flags.has_tag) {
 			RIDEBUG2("&%s:%s:%i %s %pV",
@@ -498,12 +499,13 @@ static ssize_t xlat_func_debug_attr(UNUSED TALLOC_CTX *ctx, UNUSED char **out, U
 
 		if (!RDEBUG_ENABLED4) continue;
 
-		type = fr_value_box_type_table;
-		while (type->name) {
+		for (i = 0; i < fr_value_box_type_table_len; i++) {
 			int pad;
 
 			fr_value_box_t *dst = NULL;
 
+			type = &fr_value_box_type_table[i];
+
 			if ((fr_type_t) type->value == vp->vp_type) goto next_type;
 
 			switch (type->value) {
@@ -528,7 +530,6 @@ static ssize_t xlat_func_debug_attr(UNUSED TALLOC_CTX *ctx, UNUSED char **out, U
 
 		next_type:
 			talloc_free(dst);
-			type++;
 		}
 	}
 	REXDENT();