From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 16 Oct 2023 10:42:06 +0000 (+0200)
Subject: namespace: don't retry to a mount if we didn't actually manage to create an inode
X-Git-Tag: v255-rc1~234^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=283eb4fdd157371055be4867728fa0093319af6a;p=thirdparty%2Fsystemd.git

namespace: don't retry to a mount if we didn't actually manage to create an inode
---

diff --git a/src/core/namespace.c b/src/core/namespace.c
index cb23c6c1be7..f1a24d23ad5 100644
--- a/src/core/namespace.c
+++ b/src/core/namespace.c
@@ -1636,10 +1636,11 @@ static int apply_one_mount(
                         (void) mkdir_parents(mount_entry_path(m), 0755);
 
                         q = make_mount_point_inode_from_path(what, mount_entry_path(m), 0755);
-                        if (q < 0 && q != -EEXIST)
-                                log_warning_errno(q, "Failed to create destination mount point node '%s', ignoring: %m",
-                                                  mount_entry_path(m));
-                        else
+                        if (q < 0) {
+                                if (q != -EEXIST)
+                                        log_warning_errno(q, "Failed to create destination mount point node '%s', ignoring: %m",
+                                                          mount_entry_path(m));
+                        } else
                                 try_again = true;
                 }