From: Andrew Tridgell <tridge@samba.org>
Date: Mon, 29 Sep 2008 23:51:05 +0000 (-0700)
Subject: WSPP docs say we need to check that root_dir is NULL
X-Git-Tag: samba-4.0.0alpha6~769^2~228^2~100
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=28482efa5ceebdea821b9368a2761e93ee2fff59;p=thirdparty%2Fsamba.git

WSPP docs say we need to check that root_dir is NULL
---

diff --git a/source4/rpc_server/lsa/lsa_init.c b/source4/rpc_server/lsa/lsa_init.c
index e5e31c74f83..a95cb10f9fa 100644
--- a/source4/rpc_server/lsa/lsa_init.c
+++ b/source4/rpc_server/lsa/lsa_init.c
@@ -199,6 +199,12 @@ NTSTATUS dcesrv_lsa_OpenPolicy2(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 
 	ZERO_STRUCTP(r->out.handle);
 
+	if (r->in.attr == NULL ||
+	    r->in.attr->root_dir != NULL) {
+		/* MS-LSAD 3.1.4.4.1 */
+		return NT_STATUS_INVALID_PARAMETER;
+	}
+
 	status = dcesrv_lsa_get_policy_state(dce_call, mem_ctx, &state);
 	if (!NT_STATUS_IS_OK(status)) {
 		return status;