From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sun, 21 Nov 2021 12:15:59 +0000 (+0100)
Subject: submission-login: submission-proxy - Rename target argument for submission_proxy_... 
X-Git-Tag: 2.4.0~4688
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=286449008f014fb45073dcfd616f09001a4eb62d;p=thirdparty%2Fdovecot%2Fcore.git

submission-login: submission-proxy - Rename target argument for submission_proxy_*_redirect().

It makes more sense.
---

diff --git a/src/submission-login/submission-proxy.c b/src/submission-login/submission-proxy.c
index 67a7cad08d..6cef403a93 100644
--- a/src/submission-login/submission-proxy.c
+++ b/src/submission-login/submission-proxy.c
@@ -384,14 +384,14 @@ strip_enhanced_code(const char *text, const char **enh_code_r)
 }
 
 static int
-submission_proxy_parse_redirect(const char *target, const char **userhostport_r,
+submission_proxy_parse_redirect(const char *resp, const char **userhostport_r,
 				const char **error_r)
 {
 	const char *destuser, *host;
 	struct ip_addr ip;
 	in_port_t port;
 
-	if (smtp_proxy_redirect_parse(target, &destuser, &host, &ip, &port,
+	if (smtp_proxy_redirect_parse(resp, &destuser, &host, &ip, &port,
 				      error_r) < 0)
 		return -1;
 
@@ -408,7 +408,7 @@ submission_proxy_parse_redirect(const char *target, const char **userhostport_r,
 
 static bool
 submission_proxy_handle_redirect(struct client *client, unsigned int status,
-				 const char *enh_code, const char *target,
+				 const char *enh_code, const char *resp,
 				 enum login_proxy_failure_type *failure_type_r,
 				 const char **text_r)
 {
@@ -417,11 +417,11 @@ submission_proxy_handle_redirect(struct client *client, unsigned int status,
 	if (!smtp_reply_code_is_proxy_redirect(status, enh_code))
 		return FALSE;
 
-	if (submission_proxy_parse_redirect(target, text_r, &error) < 0) {
+	if (submission_proxy_parse_redirect(resp, text_r, &error) < 0) {
 		e_debug(login_proxy_get_event(client->login_proxy),
 			"Backend server returned invalid redirect "
 			"'%03u %s %s': %s",
-			status, enh_code, str_sanitize(target, 160), error);
+			status, enh_code, str_sanitize(resp, 160), error);
 		*failure_type_r = LOGIN_PROXY_FAILURE_TYPE_AUTH_TEMPFAIL;
 		*text_r = "Temporary internal proxy error";
 		return TRUE;