From: Phil Sutter <phil@nwl.cc>
Date: Thu, 17 Aug 2017 17:09:26 +0000 (+0200)
Subject: ipntable: No need to check and assign to parms_rta
X-Git-Tag: v4.13.0~52
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=28692621442710f4a67fe33742f56efc582ee33a;p=thirdparty%2Fiproute2.git

ipntable: No need to check and assign to parms_rta

This variable is initialized at declaration and nowhere else does any
assignment to it happen, so just drop the check.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/ip/ipntable.c b/ip/ipntable.c
index 879626ee4..1837909fa 100644
--- a/ip/ipntable.c
+++ b/ip/ipntable.c
@@ -202,8 +202,6 @@ static int ipntable_modify(int cmd, int flags, int argc, char **argv)
 			if (get_u32(&queue, *argv, 0))
 				invarg("\"queue\" value is invalid", *argv);
 
-			if (!parms_rta)
-				parms_rta = (struct rtattr *)&parms_buf;
 			rta_addattr32(parms_rta, sizeof(parms_buf),
 				      NDTPA_QUEUE_LEN, queue);
 			parms_change = 1;