From: Jim Fehlig <jfehlig@suse.com>
Date: Fri, 30 Aug 2013 20:55:52 +0000 (-0600)
Subject: libxl: Add comments to libxlDriverPrivate fields
X-Git-Tag: CVE-2013-4297~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=288fdcd06d8b8b7a144613146889e74c3c850aea;p=thirdparty%2Flibvirt.git

libxl: Add comments to libxlDriverPrivate fields

Similar to the QEMU and LXC drivers, annotate the fields of
libxlDriverPrivate struct to indicate the locking rules for
their use.
---

diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h
index 83bb6b975e..95e09832c4 100644
--- a/src/libxl/libxl_conf.h
+++ b/src/libxl/libxl_conf.h
@@ -90,19 +90,26 @@ struct _libxlDriverPrivate {
      * then lockless thereafter */
     libxlDriverConfigPtr config;
 
+    /* Atomic inc/dec only */
     unsigned int nactive;
 
+    /* Immutable pointers. Caller must provide locking */
     virStateInhibitCallback inhibitCallback;
     void *inhibitOpaque;
 
+    /* Immutable pointer, self-locking APIs */
     virDomainObjListPtr domains;
 
+    /* Immutable pointer, immutable object */
     virDomainXMLOptionPtr xmlopt;
 
+    /* Immutable pointer, self-locking APIs */
     virDomainEventStatePtr domainEventState;
 
+    /* Immutable pointer, self-locking APIs */
     virPortAllocatorPtr reservedVNCPorts;
 
+    /* Immutable pointer, lockless APIs*/
     virSysinfoDefPtr hostsysinfo;
 };