From: Jan Synacek <jsynacek@redhat.com>
Date: Wed, 31 Jul 2019 14:13:35 +0000 (+0200)
Subject: analyze-security: move assert above first use of the variable (#13238)
X-Git-Tag: v243-rc2~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=28a06f5abe7acda656954627d483715478310927;p=thirdparty%2Fsystemd.git

analyze-security: move assert above first use of the variable (#13238)
---

diff --git a/src/analyze/analyze-security.c b/src/analyze/analyze-security.c
index 134b2d28c3b..dd85f282885 100644
--- a/src/analyze/analyze-security.c
+++ b/src/analyze/analyze-security.c
@@ -1514,6 +1514,8 @@ static int assess(const struct security_info *info, Table *overview_table, Analy
                 }
         }
 
+        assert(weight_sum > 0);
+
         if (details_table) {
                 size_t row;
 
@@ -1545,7 +1547,6 @@ static int assess(const struct security_info *info, Table *overview_table, Analy
                         return log_error_errno(r, "Failed to output table: %m");
         }
 
-        assert(weight_sum > 0);
         exposure = DIV_ROUND_UP(badness_sum * 100U, weight_sum);
 
         for (i = 0; i < ELEMENTSOF(badness_table); i++)