From: Jouni Malinen <j@w1.fi>
Date: Sun, 29 Jun 2014 22:47:44 +0000 (+0300)
Subject: EAP-AKA: Remove unnecessary dead increment
X-Git-Tag: hostap_2_3~187
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=28bfa291170edfbd7cf24a616eebbf8b5b52e319;p=thirdparty%2Fhostap.git

EAP-AKA: Remove unnecessary dead increment

The pos pointer is not used after this now nor in future plans, so no
need to increment the value. This remove a static analyzer warning about
dead increment.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/eap_peer/eap_aka.c b/src/eap_peer/eap_aka.c
index 28164fbb5..41361c019 100644
--- a/src/eap_peer/eap_aka.c
+++ b/src/eap_peer/eap_aka.c
@@ -151,7 +151,7 @@ static int eap_aka_ext_sim_req(struct eap_sm *sm, struct eap_aka_data *data)
 	pos += os_snprintf(pos, end - pos, ":");
 	pos += wpa_snprintf_hex(pos, end - pos, data->rand, EAP_AKA_RAND_LEN);
 	pos += os_snprintf(pos, end - pos, ":");
-	pos += wpa_snprintf_hex(pos, end - pos, data->autn, EAP_AKA_AUTN_LEN);
+	wpa_snprintf_hex(pos, end - pos, data->autn, EAP_AKA_AUTN_LEN);
 
 	eap_sm_request_sim(sm, req);
 	return 1;