From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Sat, 14 Nov 2020 20:31:03 +0000 (+0100)
Subject: codegen: Drop obsolete dedicated handling of property value-parameter
X-Git-Tag: 0.51.1~158
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=28d0ec4edda45349c76e95c8e511566df0848fa9;p=thirdparty%2Fvala.git

codegen: Drop obsolete dedicated handling of property value-parameter
---

diff --git a/codegen/valaccodememberaccessmodule.vala b/codegen/valaccodememberaccessmodule.vala
index 1f2231c55..48f224655 100644
--- a/codegen/valaccodememberaccessmodule.vala
+++ b/codegen/valaccodememberaccessmodule.vala
@@ -548,18 +548,7 @@ public abstract class Vala.CCodeMemberAccessModule : CCodeControlFlowModule {
 					(param.direction == ParameterDirection.IN && type_as_struct != null && !type_as_struct.is_simple_type () && !result.value_type.nullable)) {
 					result.cvalue = new CCodeUnaryExpression (CCodeUnaryOperator.POINTER_INDIRECTION, new CCodeIdentifier (name));
 				} else {
-					// Property setters of non simple structs shall replace all occurrences
-					// of the "value" formal parameter with a dereferencing version of that
-					// parameter.
-					if (current_property_accessor != null &&
-						current_property_accessor.writable &&
-						current_property_accessor.value_parameter == param &&
-						current_property_accessor.prop.property_type.is_real_struct_type () &&
-						!current_property_accessor.prop.property_type.nullable) {
-						result.cvalue = new CCodeUnaryExpression (CCodeUnaryOperator.POINTER_INDIRECTION, new CCodeIdentifier ("value"));
-					} else {
-						result.cvalue = get_variable_cexpression (name);
-					}
+					result.cvalue = get_variable_cexpression (name);
 				}
 				if (get_ccode_delegate_target (param) && delegate_type != null && delegate_type.delegate_symbol.has_target) {
 					var target_cname = get_ccode_delegate_target_name (param);