From: Greg Hudson <ghudson@mit.edu>
Date: Tue, 28 Jun 2016 22:01:55 +0000 (-0400)
Subject: Fix leak in ulog_replay()
X-Git-Tag: krb5-1.15-beta1~109
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2908839fcae0a12c56514d551ed1f19a7797cddb;p=thirdparty%2Fkrb5.git

Fix leak in ulog_replay()

ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller
should not also do so.

ticket: 8441 (new)
target_version: 1.14-next
target_version: 1.13-next
tags: pullup
---

diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
index d377a20422..99cda59360 100644
--- a/src/lib/kdb/kdb_log.c
+++ b/src/lib/kdb/kdb_log.c
@@ -414,10 +414,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
             if (retval)
                 goto cleanup;
         } else {
-            entry = k5alloc(sizeof(krb5_db_entry), &retval);
-            if (entry == NULL)
-                goto cleanup;
-
             retval = ulog_conv_2dbentry(context, &entry, upd);
             if (retval)
                 goto cleanup;