From: Victor Julien <victor@inliniac.net>
Date: Tue, 25 Aug 2020 09:40:50 +0000 (+0200)
Subject: flow: fix spare sync incomplete counter
X-Git-Tag: suricata-6.0.0-rc1~110
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=29148fb563d4b7dc3e348b83cc1e1a49646f1423;p=thirdparty%2Fsuricata.git

flow: fix spare sync incomplete counter
---

diff --git a/src/flow-hash.c b/src/flow-hash.c
index 6397a08018..1a92f604d1 100644
--- a/src/flow-hash.c
+++ b/src/flow-hash.c
@@ -512,10 +512,11 @@ static inline Flow *FlowSpareSync(ThreadVars *tv, FlowLookupStruct *fls,
         if (spare_sync) {
             if (f != NULL) {
                 StatsAddUI64(tv, fls->dtv->counter_flow_spare_sync_avg, fls->spare_queue.len+1);
-            } else if (f == NULL && fls->spare_queue.len == 0) {
+                if (fls->spare_queue.len < 99) {
+                    StatsIncr(tv, fls->dtv->counter_flow_spare_sync_incomplete);
+                }
+            } else if (fls->spare_queue.len == 0) {
                 StatsIncr(tv, fls->dtv->counter_flow_spare_sync_empty);
-            } else if (f != NULL && fls->spare_queue.len < 99) {
-                StatsIncr(tv, fls->dtv->counter_flow_spare_sync_incomplete);
             }
             StatsIncr(tv, fls->dtv->counter_flow_spare_sync);
         }