From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 20 Oct 2021 15:06:58 +0000 (-0400)
Subject: remove more unneeded headers
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=292656ebef5a0ab4bba4395b25f11afa21460294;p=thirdparty%2Ffreeradius-server.git

remove more unneeded headers

and make sure that the necessary headers are included
---

diff --git a/src/protocols/dhcpv4/raw.c b/src/protocols/dhcpv4/raw.c
index f809ac16fc2..89389dc5b61 100644
--- a/src/protocols/dhcpv4/raw.c
+++ b/src/protocols/dhcpv4/raw.c
@@ -34,8 +34,6 @@
 #include <freeradius-devel/util/types.h>
 #include <freeradius-devel/util/udpfromto.h>
 
-#include <stddef.h>
-#include <stdint.h>
 #include <sys/ioctl.h>
 
 #ifdef HAVE_SYS_SOCKET_H
diff --git a/src/protocols/dhcpv4/udp.c b/src/protocols/dhcpv4/udp.c
index bee0e6ee3a5..4357c7ea00c 100644
--- a/src/protocols/dhcpv4/udp.c
+++ b/src/protocols/dhcpv4/udp.c
@@ -33,16 +33,6 @@
 #include <freeradius-devel/util/syserror.h>
 #include <freeradius-devel/util/talloc.h>
 
-#include <stdint.h>
-#include <stddef.h>
-
-#ifdef HAVE_SYS_SOCKET_H
-#  include <sys/socket.h>
-#endif
-#ifdef HAVE_SYS_TYPES_H
-#  include <sys/types.h>
-#endif
-
 /** Send DHCP packet using a connectionless UDP socket
  *
  * @param packet to send
diff --git a/src/protocols/dhcpv6/base.c b/src/protocols/dhcpv6/base.c
index 9227b3d2e30..55146cb6c19 100644
--- a/src/protocols/dhcpv6/base.c
+++ b/src/protocols/dhcpv6/base.c
@@ -34,8 +34,6 @@
 #include <freeradius-devel/util/rand.h>
 #include <freeradius-devel/util/talloc.h>
 #include <freeradius-devel/util/types.h>
-#include <stddef.h>
-#include <stdint.h>
 
 #include "dhcpv6.h"
 #include "attrs.h"
diff --git a/src/protocols/dns/decode.c b/src/protocols/dns/decode.c
index 1bbc4a5bc00..6efd445ecac 100644
--- a/src/protocols/dns/decode.c
+++ b/src/protocols/dns/decode.c
@@ -27,11 +27,8 @@
  */
 #include <freeradius-devel/io/test_point.h>
 #include <freeradius-devel/util/dns.h>
-#include <freeradius-devel/util/pair.h>
 #include <freeradius-devel/util/proto.h>
 #include <freeradius-devel/util/struct.h>
-#include <freeradius-devel/util/talloc.h>
-#include <freeradius-devel/util/types.h>
 
 #include "dns.h"
 #include "attrs.h"
diff --git a/src/protocols/dns/encode.c b/src/protocols/dns/encode.c
index f8e3406146b..65aee1d9be9 100644
--- a/src/protocols/dns/encode.c
+++ b/src/protocols/dns/encode.c
@@ -27,11 +27,8 @@
 #include <freeradius-devel/io/test_point.h>
 #include <freeradius-devel/util/dbuff.h>
 #include <freeradius-devel/util/dns.h>
-#include <freeradius-devel/util/pair.h>
 #include <freeradius-devel/util/proto.h>
 #include <freeradius-devel/util/struct.h>
-#include <freeradius-devel/util/talloc.h>
-#include <freeradius-devel/util/types.h>
 
 #include "dns.h"
 #include "attrs.h"
diff --git a/src/protocols/internal/encode.c b/src/protocols/internal/encode.c
index bac0a385a55..04ecfca51ac 100644
--- a/src/protocols/internal/encode.c
+++ b/src/protocols/internal/encode.c
@@ -30,8 +30,6 @@
 #include <freeradius-devel/io/test_point.h>
 #include <freeradius-devel/util/net.h>
 #include <freeradius-devel/util/proto.h>
-#include <freeradius-devel/util/dbuff.h>
-#include <freeradius-devel/util/talloc.h>
 
 /** We use the same header for all types
  *
diff --git a/src/protocols/radius/abinary.c b/src/protocols/radius/abinary.c
index 97d2b117362..4ef0aee3a90 100644
--- a/src/protocols/radius/abinary.c
+++ b/src/protocols/radius/abinary.c
@@ -25,12 +25,9 @@ RCSID("$Id$")
 #include <freeradius-devel/util/base16.h>
 #include <freeradius-devel/util/misc.h>
 #include <freeradius-devel/util/pair.h>
-#include <freeradius-devel/util/talloc.h>
 
 #include "radius.h"
 
-#include <ctype.h>
-
 /*
  * Two types of filters are supported, GENERIC and IP.  The identifiers
  * are:
diff --git a/src/protocols/radius/base.c b/src/protocols/radius/base.c
index a31c3cdc1a0..f234cf66512 100644
--- a/src/protocols/radius/base.c
+++ b/src/protocols/radius/base.c
@@ -33,7 +33,6 @@ RCSID("$Id$")
 #include <freeradius-devel/io/pair.h>
 #include <freeradius-devel/util/md5.h>
 #include <freeradius-devel/util/net.h>
-#include <freeradius-devel/util/talloc.h>
 #include <freeradius-devel/util/udp.h>
 #include <freeradius-devel/protocol/radius/freeradius.internal.h>
 
diff --git a/src/protocols/radius/encode.c b/src/protocols/radius/encode.c
index 4d09d34fed5..8e59f0edd7e 100644
--- a/src/protocols/radius/encode.c
+++ b/src/protocols/radius/encode.c
@@ -27,7 +27,6 @@ RCSID("$Id$")
 #include <freeradius-devel/util/dbuff.h>
 #include <freeradius-devel/util/md5.h>
 #include <freeradius-devel/util/struct.h>
-#include <freeradius-devel/util/net.h>
 #include <freeradius-devel/io/test_point.h>
 #include <freeradius-devel/protocol/radius/freeradius.internal.h>
 #include "attrs.h"
diff --git a/src/protocols/radius/packet.c b/src/protocols/radius/packet.c
index e6e442d858f..b08c0cd3371 100644
--- a/src/protocols/radius/packet.c
+++ b/src/protocols/radius/packet.c
@@ -27,11 +27,9 @@ RCSID("$Id$")
 #include "attrs.h"
 
 #include <freeradius-devel/util/udp.h>
-#include <freeradius-devel/util/udpfromto.h>
 #include <freeradius-devel/util/syserror.h>
 
 #include <fcntl.h>
-#include <ctype.h>
 
 typedef struct {
 	uint8_t	code;
diff --git a/src/protocols/radius/tcp.c b/src/protocols/radius/tcp.c
index b08fc6c43cd..d63306e4c28 100644
--- a/src/protocols/radius/tcp.c
+++ b/src/protocols/radius/tcp.c
@@ -25,6 +25,7 @@
 RCSID("$Id$")
 
 #include <freeradius-devel/radius/radius.h>
+#include <freeradius-devel/util/syserror.h>
 #include "tcp.h"
 
 fr_radius_packet_t *fr_tcp_recv(int sockfd, int flags)
diff --git a/src/protocols/tacacs/base.c b/src/protocols/tacacs/base.c
index 9fce4df8d4b..a434a1bf180 100644
--- a/src/protocols/tacacs/base.c
+++ b/src/protocols/tacacs/base.c
@@ -25,7 +25,6 @@
  */
 #include <freeradius-devel/util/net.h>
 #include <freeradius-devel/util/md5.h>
-#include <freeradius-devel/util/debug.h>
 #include <freeradius-devel/util/struct.h>
 
 #include "tacacs.h"
diff --git a/src/protocols/tacacs/encode.c b/src/protocols/tacacs/encode.c
index 6f32777a2f5..937996a60c7 100644
--- a/src/protocols/tacacs/encode.c
+++ b/src/protocols/tacacs/encode.c
@@ -27,8 +27,6 @@
 #include <freeradius-devel/io/test_point.h>
 #include <freeradius-devel/protocol/tacacs/tacacs.h>
 #include <freeradius-devel/util/dbuff.h>
-#include <freeradius-devel/util/debug.h>
-#include <freeradius-devel/util/net.h>
 #include <freeradius-devel/util/rand.h>
 #include <freeradius-devel/util/struct.h>