From: Niklas Söderlund Date: Thu, 3 Jul 2025 21:42:06 +0000 (+0200) Subject: media: i2c: imx290: Remove unneeded assignment of subdev device pointer X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2946bac895e3f1d9a1a97a726339ed3e4d439d19;p=thirdparty%2Flinux.git media: i2c: imx290: Remove unneeded assignment of subdev device pointer The core helper v4l2_i2c_subdev_init() already assignees the subdevices dev pointer to the device associated with the i2c client passed to it. And 'imx290->dev' is assigned to '&client->dev' already in probe before calling imx290_subdev_init(). Remove the duplicated open-coded assignment in the driver, there is no reason to do it twice. Signed-off-by: Niklas Söderlund Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index fbf7eba3d71d8..4f3f386c53534 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -1294,7 +1294,6 @@ static int imx290_subdev_init(struct imx290 *imx290) * will already be prevented even before the delay. */ v4l2_i2c_subdev_init(&imx290->sd, client, &imx290_subdev_ops); - imx290->sd.dev = imx290->dev; pm_runtime_mark_last_busy(imx290->dev); pm_runtime_put_autosuspend(imx290->dev);