From: Steven Baigal (sbaigal) <sbaigal@cisco.com>
Date: Wed, 14 Dec 2022 15:18:26 +0000 (+0000)
Subject: Pull request #3702: stream: ignore PAWS timestamp checks when in no_ack mode
X-Git-Tag: 3.1.49.0~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=296a8c5b8c79fa7db472ca8c60752f50c5f9fabd;p=thirdparty%2Fsnort3.git

Pull request #3702: stream: ignore PAWS timestamp checks when in no_ack mode

Merge in SNORT/snort3 from ~JALIIMRA/snort3:paws_ts_check to master

Squashed commit of the following:

commit f7307eba55b333bd74d32b466d686176a6edf5f3
Author: Juweria Ali Imran <jaliimra@cisco.com>
Date:   Wed Dec 7 10:26:07 2022 -0500

    stream: ignore PAWS timestamp checks when in no_ack mode
---

diff --git a/src/stream/tcp/tcp_session.cc b/src/stream/tcp/tcp_session.cc
index 7a69e9752..a88229e94 100644
--- a/src/stream/tcp/tcp_session.cc
+++ b/src/stream/tcp/tcp_session.cc
@@ -696,7 +696,11 @@ void TcpSession::update_paws_timestamps(TcpSegmentDescriptor& tsd)
     TcpStreamTracker* listener = tsd.get_listener();
     TcpStreamTracker* talker = tsd.get_talker();
 
-    if ( listener->normalizer.handling_timestamps()
+    if ( no_ack_mode_enabled() )
+    { 
+        talker->set_ts_last(0); 
+    }
+    else if ( listener->normalizer.handling_timestamps()
         && SEQ_EQ(listener->r_win_base, tsd.get_seq()) )
     {
         if ( ((int32_t)(tsd.get_timestamp() - talker->get_ts_last()) >= 0  )