From: Julian Seward <jseward@acm.org>
Date: Tue, 3 Feb 2015 18:01:41 +0000 (+0000)
Subject: dis_VMASKMOV: create per-lane transfer/no-transfer guard expressions
X-Git-Tag: svn/VALGRIND_3_11_0^2~101
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=296c48234cb08efd7e06f35c2978f2a7c7e59f29;p=thirdparty%2Fvalgrind.git

dis_VMASKMOV: create per-lane transfer/no-transfer guard expressions
that are more Memcheck-friendly.  No functional change.


git-svn-id: svn://svn.valgrind.org/vex/trunk@3081
---

diff --git a/VEX/priv/guest_amd64_toIR.c b/VEX/priv/guest_amd64_toIR.c
index d6d3a17ae5..5e9d0bd647 100644
--- a/VEX/priv/guest_amd64_toIR.c
+++ b/VEX/priv/guest_amd64_toIR.c
@@ -27272,11 +27272,15 @@ static ULong dis_VMASKMOV ( Bool *uses_vvvv, const VexAbiInfo* vbi,
    Int nLanes = (isYMM ? 2 : 1) * (laneIs32 ? 4 : 2);
 
    for (i = 0; i < nLanes; i++) {
-      IRTemp cond = newTemp(Ity_I1);
-      assign( cond,
-              binop(laneIs32 ? Iop_CmpLT32S : Iop_CmpLT64S,
-                    (laneIs32 ? getYMMRegLane32 : getYMMRegLane64)( rV, i ),
-                    mkU(ty, 0) ));
+      IRExpr* shAmt = laneIs32 ? mkU8(31)    : mkU8(63);
+      IRExpr* one   = laneIs32 ? mkU32(1)    : mkU64(1);
+      IROp    opSHR = laneIs32 ? Iop_Shr32   : Iop_Shr64;
+      IROp    opEQ  = laneIs32 ? Iop_CmpEQ32 : Iop_CmpEQ64;
+      IRExpr* lane  = (laneIs32 ? getYMMRegLane32 : getYMMRegLane64)( rV, i );
+
+      IRTemp  cond = newTemp(Ity_I1);
+      assign(cond, binop(opEQ, binop(opSHR, lane, shAmt), one));
+
       IRTemp  data = newTemp(ty);
       IRExpr* ea   = binop(Iop_Add64, mkexpr(addr),
                                       mkU64(i * (laneIs32 ? 4 : 8)));