From: Ondřej Surý <ondrej@isc.org>
Date: Wed, 2 Apr 2025 16:06:52 +0000 (+0200)
Subject: Don't copy EDE codes if source is same as destination
X-Git-Tag: v9.21.7~3^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2988ebae214846d6f8efa41d058aa34f7285a7dc;p=thirdparty%2Fbind9.git

Don't copy EDE codes if source is same as destination

If the nested DNS validator ends up in the same fetch because of the
loops, the code could be copying the EDE codes from the same source EDE
context as the destination EDE context.  Skip copying the EDE codes if
the source and the destination is the same.
---

diff --git a/lib/dns/ede.c b/lib/dns/ede.c
index 7fbbd839050..af7cc0b57f7 100644
--- a/lib/dns/ede.c
+++ b/lib/dns/ede.c
@@ -134,6 +134,10 @@ dns_ede_copy(dns_edectx_t *edectx_to, const dns_edectx_t *edectx_from) {
 	REQUIRE(DNS_EDE_VALID(edectx_to));
 	REQUIRE(DNS_EDE_VALID(edectx_from));
 
+	if (edectx_to == edectx_from) {
+		return;
+	}
+
 	for (size_t pos = 0; pos < DNS_EDE_MAX_ERRORS; pos++) {
 		uint16_t fromcode;