From: Andreas Steffen <andreas.steffen@strongswan.org>
Date: Tue, 5 Feb 2008 19:27:05 +0000 (-0000)
Subject: some websites append a newline character to a DER-encoded binary blob
X-Git-Tag: 4.1.11~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=298c9c8eed4f5178acfcaa9cc65ebb802ee2e7ed;p=thirdparty%2Fstrongswan.git

some websites append a newline character to a DER-encoded binary blob
---

diff --git a/src/libstrongswan/asn1/asn1.c b/src/libstrongswan/asn1/asn1.c
index f692a43396..b53f5a7665 100644
--- a/src/libstrongswan/asn1/asn1.c
+++ b/src/libstrongswan/asn1/asn1.c
@@ -677,13 +677,23 @@ bool is_asn1(chunk_t blob)
 		DBG2("  file content is not binary ASN.1");
 		return FALSE;
 	}
+
 	len = asn1_length(&blob);
-	if (len != blob.len)
+
+	/* exact match */
+	if (len == blob.len)
 	{
-		DBG2("  file size does not match ASN.1 coded length");
-		return FALSE;
+		return TRUE;
 	}
-	return TRUE;
+
+	/* some websites append a surplus newline character to the blob */
+	if (len + 1 == blob.len && *(blob.ptr + len) == '\n')
+	{
+		return TRUE;
+	}
+
+	DBG2("  file size does not match ASN.1 coded length");
+	return FALSE;
 }
 
 /**
diff --git a/src/pluto/asn1.c b/src/pluto/asn1.c
index dafc6b19c6..bcfdca15e1 100644
--- a/src/pluto/asn1.c
+++ b/src/pluto/asn1.c
@@ -758,13 +758,23 @@ is_asn1(chunk_t blob)
 	)
 	return FALSE;
     }
+
     len = asn1_length(&blob);
-    if (len != blob.len)
+ 
+    /* exact match */
+    if (len == blob.len)
     {
-	DBG(DBG_PARSING,
-	    DBG_log("  file size does not match ASN.1 coded length");
-	)
-	return FALSE;
+	return TRUE;
     }
-    return TRUE;
+
+    /* some websites append a surplus newline character to the blob */
+    if (len + 1 == blob.len && *(blob.ptr + len) == '\n')
+    {
+	return TRUE;
+    }
+
+    DBG(DBG_PARSING,
+	DBG_log("  file size does not match ASN.1 coded length");
+    )
+    return FALSE;
 }