From: Volker Lendecke <vl@samba.org>
Date: Wed, 9 May 2012 08:56:54 +0000 (+0200)
Subject: s3: Fix Coverity ID 242718 Uninitialized scalar variable
X-Git-Tag: samba-4.0.0alpha21~222
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a03d9e42c71bc164936d3e46e1240494ca33bd5;p=thirdparty%2Fsamba.git

s3: Fix Coverity ID 242718 Uninitialized scalar variable

In an error path we are closing user_pol without opening it
---

diff --git a/source3/rpcclient/cmd_samr.c b/source3/rpcclient/cmd_samr.c
index 196e40fd334..ebc13c33347 100644
--- a/source3/rpcclient/cmd_samr.c
+++ b/source3/rpcclient/cmd_samr.c
@@ -2703,7 +2703,8 @@ static NTSTATUS cmd_samr_chgpasswd(struct rpc_pipe_client *cli,
 				   TALLOC_CTX *mem_ctx,
 				   int argc, const char **argv)
 {
-	struct policy_handle connect_pol, domain_pol, user_pol;
+	struct policy_handle connect_pol, domain_pol;
+	struct policy_handle user_pol = { 0, };
 	NTSTATUS status, result;
 	const char *user, *oldpass, *newpass;
 	uint32 access_mask = MAXIMUM_ALLOWED_ACCESS;