From: Tom Hromatka Date: Tue, 7 Jan 2020 14:50:03 +0000 (-0700) Subject: cgrulesengd: Fix Coverity warnings about a socket leak X-Git-Tag: v0.42~3^2~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a0fff4c935573fb441839adca296dc14118cb7d;p=thirdparty%2Flibcgroup.git cgrulesengd: Fix Coverity warnings about a socket leak This commit resolves the following Coverity warnings: CID 1412123 (#1 of 1): Resource leak (RESOURCE_LEAK)12. leaked_handle: Handle variable sk_nl going out of scope leaks the handle. CID 1412129 (#1 of 1): Resource leak (RESOURCE_LEAK)13. leaked_handle: Handle variable sk_unix going out of scope leaks the handle. Signed-off-by: Tom Hromatka --- diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c index 5efc00eb..4cef53ee 100644 --- a/src/daemon/cgrulesengd.c +++ b/src/daemon/cgrulesengd.c @@ -792,9 +792,9 @@ static int cgre_create_netlink_socket_process_msg(void) } close_and_exit: - if (sk_nl > 0) + if (sk_nl >= 0) close(sk_nl); - if (sk_unix > 0) + if (sk_unix >= 0) close(sk_unix); return rc; }