From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Wed, 23 Jul 2025 15:54:08 +0000 (+0100)
Subject: clk: versaclock: Use IS_ERR check before dereference
X-Git-Tag: v2026.01-rc2~79^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a13b59ed4317ec4483d1502d9db161f46985a32;p=thirdparty%2Fu-boot.git

clk: versaclock: Use IS_ERR check before dereference

In versaclock_probe vc5->pin_xin may be an error pointer so need to
check with IS_ERR before attempting to dereference it.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---

diff --git a/drivers/clk/clk_versaclock.c b/drivers/clk/clk_versaclock.c
index 790ea4dbe82..19a787eaf0c 100644
--- a/drivers/clk/clk_versaclock.c
+++ b/drivers/clk/clk_versaclock.c
@@ -904,12 +904,12 @@ int versaclock_probe(struct udevice *dev)
 	if (IS_ERR(mux_name))
 		return PTR_ERR(mux_name);
 
-	clk_register(&vc5->clk_mux, "versaclock-mux", mux_name, vc5->pin_xin->dev->name);
-
-	if (!IS_ERR(vc5->pin_xin))
+	if (!IS_ERR(vc5->pin_xin)) {
+		clk_register(&vc5->clk_mux, "versaclock-mux", mux_name, vc5->pin_xin->dev->name);
 		vc5_mux_set_parent(&vc5->clk_mux, 1);
-	else
+	} else {
 		vc5_mux_set_parent(&vc5->clk_mux, 0);
+	}
 
 	/* Configure Optional Loading Capacitance for external XTAL */
 	if (!(vc5->chip_info->flags & VC5_HAS_INTERNAL_XTAL)) {