From: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Date: Thu, 18 Sep 2008 14:15:05 +0000 (+0200)
Subject: Revert "Fix for the empty string (REG_SZ) problem"
X-Git-Tag: samba-4.0.0alpha6~784
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a267e6da524c5dc69b3e2d97114f17461567856;p=thirdparty%2Fsamba.git

Revert "Fix for the empty string (REG_SZ) problem"

This reverts commit d994520885301f1dfd04363bab05c9238ce5ae05.
This shouldn't be fixed in the general character conversion library but directly in the registry library.
---

diff --git a/source4/lib/charset/iconv.c b/source4/lib/charset/iconv.c
index 9b15cfb3cca..d4f930b4622 100644
--- a/source4/lib/charset/iconv.c
+++ b/source4/lib/charset/iconv.c
@@ -600,14 +600,6 @@ static size_t utf8_push(void *cd, const char **inbuf, size_t *inbytesleft,
 	uint8_t *c = (uint8_t *)*outbuf;
 	const uint8_t *uc = (const uint8_t *)*inbuf;
 
-	/* Special case: Windows (e.g. "regedit") also expects an empty buffer
- 	   with length 1 as a valid empty UTF8 string */
-	if (in_left == 1 && uc[0] == 0 && out_left >= 1) {
-		c[0] = uc[0];
-		in_left  -= 1;
-		out_left -= 1;
-	}
-
 	while (in_left >= 2 && out_left >= 1) {
 		unsigned int codepoint;