From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 5 May 2016 06:42:50 +0000 (+0200)
Subject: virNetServerClientNewPostExecRestart: Drop useless typecasts
X-Git-Tag: v1.3.5-rc1~368
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2a3a2c2f5bea5d5cafba3b96c843acd67f791098;p=thirdparty%2Flibvirt.git

virNetServerClientNewPostExecRestart: Drop useless typecasts

In this function, @id is defined as unsigned long long. When
passing this variable to virJSONValueObjectGetNumberUlong(),
well address of this variable, it's typecasted to ull*. There
is no need for that. It's a same story with @nrequests_max.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
index d38f42140d..d3a3a18f93 100644
--- a/src/rpc/virnetserverclient.c
+++ b/src/rpc/virnetserverclient.c
@@ -485,7 +485,7 @@ virNetServerClientPtr virNetServerClientNewPostExecRestart(virJSONValuePtr objec
         return NULL;
     }
     if (virJSONValueObjectGetNumberUint(object, "nrequests_max",
-                                        (unsigned int *)&nrequests_max) < 0) {
+                                        &nrequests_max) < 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("Missing nrequests_client_max field in JSON state document"));
         return NULL;
@@ -501,8 +501,7 @@ virNetServerClientPtr virNetServerClientNewPostExecRestart(virJSONValuePtr objec
         /* no ID found in, a new one must be generated */
         id = virNetServerNextClientID((virNetServerPtr) opaque);
     } else {
-        if (virJSONValueObjectGetNumberUlong(object, "id",
-                                        (unsigned long long *) &id) < 0) {
+        if (virJSONValueObjectGetNumberUlong(object, "id", &id) < 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("Malformed id field in JSON state document"));
         return NULL;